Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bitwarden Secrets provider #513

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat: Bitwarden Secrets provider #513

merged 1 commit into from
Sep 6, 2024
+354 −38

Conversation

carnei-ro
Copy link
Contributor

adds Bitwarden Secrets
closes #427

This provider uses the Bitwarden SDK Go, which needs GCO enabled and musl-tools to compile (linux), check this doc.

Use ref+bws://<PROJECT_NAME>/<SECRET_NAME> to fetch the secret value.

$ make build
CGO_ENABLED=1 CC=clang CXX=clang++ go build -ldflags '-X main.version=v0.37.3-56-g8a1c52c-dirty -X main.commit=8a1c52c880fe3a40e0c65035b6ab5f8e742b7534' -o bin/vals ./cmd/vals

$ cat myyaml.yaml 
baz:
  mykey:
    simple_secret: ref+bws://vals-test/fooKey
    yaml: |
      ref+bws://vals-test/myYAML
    parsing_yaml_secret: ref+bws://vals-test/myYAML#baz

$ cat myyaml.yaml | bin/vals eval
baz:
  mykey:
    parsing_yaml_secret: qux
    simple_secret: myValue
    yaml: |
      foo: bar
      baz: qux

$ env | grep BWS_
BWS_ORGANIZATION_ID=d2f88df6-REDA-CTED-0000-000000000000
BWS_ACCESS_TOKEN=0.b5a15cb4-REDA-CTED-0000-000000000000.abcdefghijklmnopqrstuvwxyzABCD:aSBsb3ZlIHZhbHMgISAhCg==

The test is passing:

$ go test -run TestValues_BitwardenSecrets_String .
ok      github.com/helmfile/vals        7.151s

image

@carnei-ro carnei-ro force-pushed the feat/bitwarden-secrets-manager branch 7 times, most recently from bbdc981 to c1f6e7a Compare September 6, 2024 18:17
@carnei-ro carnei-ro force-pushed the feat/bitwarden-secrets-manager branch 2 times, most recently from d69012f to bb7b813 Compare September 6, 2024 19:29
@carnei-ro
feat: Bitwarden Secrets provider
2fea060 
Signed-off-by: Leandro Carneiro <leandro@carnei.ro>
@carnei-ro carnei-ro force-pushed the feat/bitwarden-secrets-manager branch from fd5e146 to 2fea060 Compare September 6, 2024 19:45
@zhaque44 zhaque44 self-assigned this Sep 6, 2024
@zhaque44 zhaque44 merged commit 5378cfa into helmfile:main Sep 6, 2024
4 checks passed
@carnei-ro carnei-ro deleted the feat/bitwarden-secrets-manager branch September 6, 2024 20:23
@yxxhero
Copy link
Member

yxxhero commented Sep 7, 2024

@zhaque44 this PR broken many build process.

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Sep 7, 2024
Closed
zhaque44 added a commit to zhaque44/vals that referenced this pull request Sep 7, 2024
@zhaque44
Revert "Merge pull request helmfile#513 from carnei-ro/feat/bitwarden…
e78b634 
…-secrets-manager"

This reverts commit 5378cfa, reversing
changes made to 35d76ca.
zhaque44 added a commit to zhaque44/vals that referenced this pull request Sep 7, 2024
@zhaque44
Revert "Merge pull request helmfile#513 from carnei-ro/feat/bitwarden…
703242f 
…-secrets-manager"

This reverts commit 5378cfa, reversing
changes made to 35d76ca.

Signed-off-by: zhaque44 <haque.zubair@gmail.com>
yxxhero pushed a commit that referenced this pull request Sep 7, 2024
@zhaque44
Revert "Merge pull request #513 from carnei-ro/feat/bitwarden-secrets…
4e977c5 
…-manager" (#515)

This reverts commit 5378cfa, reversing
changes made to 35d76ca.

Signed-off-by: zhaque44 <haque.zubair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaque44 zhaque44 zhaque44 left review comments

@mumoshu mumoshu Awaiting requested review from mumoshu mumoshu is a code owner

@itscaro itscaro Awaiting requested review from itscaro itscaro is a code owner

@yxxhero yxxhero Awaiting requested review from yxxhero yxxhero is a code owner

@xiaomudk xiaomudk Awaiting requested review from xiaomudk xiaomudk is a code owner

Assignees

@zhaque44 zhaque44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: support Bitwarden Secrets Manager
3 participants
@carnei-ro @yxxhero @zhaque44